dpgaspar commented on code in PR #28387: URL: https://github.com/apache/superset/pull/28387#discussion_r1594259162
########## superset/views/css_templates.py: ########## @@ -54,8 +48,15 @@ def list(self) -> FlaskResponse: class CssTemplateAsyncModelView( # pylint: disable=too-many-ancestors CssTemplateModelView ): - include_route_methods = {RouteMethod.API_READ} + include_route_methods = RouteMethod.API_READ class_permission_name = "CssTemplate" method_permission_name = MODEL_VIEW_RW_METHOD_PERMISSION_MAP list_columns = ["template_name", "css"] + + @expose_api(name="read", url="/api/read", methods=["GET"]) + @has_access_api + @permission_name("list") + @deprecated(eol_version="5.0.0") Review Comment: Could we just remove this? not used on the frontend and a REST API exists for this for some time now -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org