justinpark commented on code in PR #27857:
URL: https://github.com/apache/superset/pull/27857#discussion_r1594501119
##########
superset/models/dashboard.py:
##########
@@ -242,6 +242,12 @@ def changed_by_name(self) -> str:
return ""
return str(self.changed_by)
+ @property
Review Comment:
@michael-s-molina This case is different. The property 'created_by' does not
currently exist, therefore it is being added as a new property. The interface
used for this addition is 'changed_by_name', which closely resembles the
desired shape.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
