rusackas commented on code in PR #28349:
URL: https://github.com/apache/superset/pull/28349#discussion_r1596034560
##########
superset-frontend/src/components/InfoTooltip/index.tsx:
##########
@@ -83,7 +83,11 @@ export default function InfoTooltip({
overlayStyle={overlayStyle}
color={bgColor}
>
- <Icons.InfoSolidSmall className="info-solid-small" viewBox={viewBox} />
+ <Icons.InfoSolidSmall
+ className="info-solid-small"
+ viewBox={viewBox}
+ iconSize="m"
Review Comment:
At a minimum, we could set up the InfoTooltip to take an optional iconSize
parameter and take it in here. Then, in the other file, instead of
`<InfoTooltip tooltip={toolTipDescription} />` you could use `<InfoTooltip
tooltip={toolTipDescription} iconSize="m" />`. Then it would only affect the
one instance instead of all InfoTooltips in the app.
I swear we had another trick to vertically align these icons, though,
besides making them teensy.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
