michael-s-molina commented on code in PR #28432: URL: https://github.com/apache/superset/pull/28432#discussion_r1600455839
########## tests/unit_tests/common/test_time_shifts.py: ########## @@ -0,0 +1,187 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +from pandas import DataFrame, Series, Timestamp +from pandas.testing import assert_frame_equal +from pytest import fixture, mark + +from superset.common.chart_data import ChartDataResultFormat, ChartDataResultType +from superset.common.query_context import QueryContext +from superset.common.query_context_processor import QueryContextProcessor +from superset.connectors.sqla.models import BaseDatasource +from superset.constants import TimeGrain + +query_context_processor = QueryContextProcessor( + QueryContext( + datasource=BaseDatasource(), + queries=[], + result_type=ChartDataResultType.COLUMNS, + form_data={}, + slice_=None, + result_format=ChartDataResultFormat.CSV, + cache_values={}, + ) +) + + +@fixture +def make_join_column_producer(): + def join_column_producer(row: Series, column_index: int) -> str: + return "CUSTOM_FORMAT" + + return join_column_producer + + +@mark.parametrize( + ("time_grain", "expected"), + [ + (TimeGrain.WEEK, "2020-W01"), + (TimeGrain.MONTH, "2020-01"), + (TimeGrain.QUARTER, "2020-Q1"), + (TimeGrain.YEAR, "2020"), + ], +) +def test_join_column(time_grain: str, expected: str): + df = DataFrame({"ds": [Timestamp("2020-01-07")]}) + column_name = "join_column" + query_context_processor.add_offset_join_column(df, column_name, time_grain) + result = DataFrame({"ds": [Timestamp("2020-01-07")], column_name: [expected]}) + assert_frame_equal(df, result) + + +def test_join_column_producer(make_join_column_producer): + df = DataFrame({"ds": [Timestamp("2020-01-07")]}) + column_name = "join_column" + query_context_processor.add_offset_join_column( + df, column_name, TimeGrain.YEAR, None, make_join_column_producer + ) + result = DataFrame( + {"ds": [Timestamp("2020-01-07")], column_name: ["CUSTOM_FORMAT"]} + ) + assert_frame_equal(df, result) + + +def test_join_offset_dfs_no_offsets(): + df = DataFrame({"A": ["2021-01-01", "2021-02-01", "2021-03-01"]}) + offset_dfs = {} + time_grain = "YEAR" + join_keys = ["A"] + + result = query_context_processor.join_offset_dfs( + df, offset_dfs, time_grain, join_keys + ) + + assert_frame_equal(df, result) + + +def test_join_offset_dfs_with_offsets(): + df = DataFrame({"A": ["2021-01-01", "2021-02-01", "2021-03-01"]}) Review Comment: Their content depends on the test case for most of them. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
