hanslemm opened a new pull request, #28762: URL: https://github.com/apache/superset/pull/28762
### SUMMARY This PR allows Helm deployments to use custom autoscaling solutions. In my company, we don't use the Kubernetes metrics server for autoscaling, but rather [Keda](https://keda.sh/) with Prometheus metrics. With that in mind, the current Helm deployment doesn't work for me, as the HPA cannot find the metrics to autoscale. This PR introduces a `.Values.supersetNode.autoscaling.custom` and `.Values.supersetWorker.autoscaling.custom` bool keys that: - If `.Values.supersetNode.autoscaling.enabled is TRUE and .Values.supersetNode.custom is FALSE` then creates HPA for Node and removes ReplicaCount for Node deployment. - If `.Values.supersetNode.autoscaling.enabled is TRUE and .Values.supersetNode.custom is TRUE` then it *does not* create HPA for Node and removes ReplicaCount for Node deployment. - If `.Values.supersetNode.autoscaling.enabled is FALSE` then no autoscaling logic is enabled. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF <!--- Skip this if not applicable --> ### TESTING INSTRUCTIONS <!--- Required! What steps can be taken to manually verify the changes? --> ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
