rusackas commented on code in PR #28784:
URL: https://github.com/apache/superset/pull/28784#discussion_r1622892232
##########
superset-frontend/webpack.config.js:
##########
@@ -496,7 +496,7 @@ const config = {
'react/lib/ReactContext': true,
},
plugins,
- devtool: 'source-map',
+ devtool: isDevMode ? 'source-map' : false,
Review Comment:
The source maps are SUPER helpful in prod, actually... it allows us to help
pinpoint runtime errors in the codebase rather than see garbage minimized JS
and stacktraces. I would leave these on.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
