michael-s-molina commented on code in PR #28780:
URL: https://github.com/apache/superset/pull/28780#discussion_r1627802352
##########
superset/utils/pandas_postprocessing/histogram.py:
##########
@@ -53,7 +53,7 @@ def histogram(
raise ValueError(f"The column '{column}' must be numeric.")
# calculate the histogram bin edges
- bin_edges = np.histogram_bin_edges(df[column], bins=bins)
+ bin_edges = np.histogram_bin_edges(df[column].dropna(), bins=bins)
Review Comment:
I added the `dropna()` to deal with `NULL` values independently of the query
results.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
