mistercrunch commented on code in PR #29077:
URL: https://github.com/apache/superset/pull/29077#discussion_r1628034739


##########
.github/workflows/superset-e2e.yml:
##########
@@ -20,12 +34,12 @@ jobs:
       pull-requests: read
     strategy:
       # when one test fails, DO NOT cancel the other
-      # containers, because this will kill Cypress processes
+      # parallel_id, because this will kill Cypress processes
       # leaving the Dashboard hanging ...
       # https://github.com/cypress-io/github-action/issues/48
       fail-fast: false
       matrix:
-        containers: [1, 2, 3]
+        parallel_id: [0, 1, 2, 3, 4, 5]

Review Comment:
   right, there's like 7 minutes of setup and in aggregate maybe 45 minutes of 
parallelizable stuff. At 6 workers it's about 50/50 of the time on overhead VS 
work. I thought bumping this up made some sense as it has now become the 
bottleneck as the longest CI workflow.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

Reply via email to