Re: [PR] feat(echarts-pie): add string template support for labels [superset]

[via GitHub]

rusackas commented on PR #28774:
URL: https://github.com/apache/superset/pull/28774#issuecomment-2150977403

   > @rusackas @michael-s-molina
   > 
   > > I guess we could elaborate more here (like what a/b/c/d are) but it's 
there! :D
   > 
   > Does this look good? <img alt="image" width="251" 
src="https://private-user-images.githubusercontent.com/157834442/337006156-20095a48-7124-46e6-b638-62153127bf06.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTc2MjIyOTYsIm5iZiI6MTcxNzYyMTk5NiwicGF0aCI6Ii8xNTc4MzQ0NDIvMzM3MDA2MTU2LTIwMDk1YTQ4LTcxMjQtNDZlNi1iNjM4LTYyMTUzMTI3YmYwNi5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjQwNjA1JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI0MDYwNVQyMTEzMTZaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT0wM2VlMzg5NzA2NTRiYWY0ZjZjY2I0MGMxNTk5ZDBmZWE2ZjE2YzkyZTNjMGJmNDY2ZDNjZGJiMzhlNGEzYzAyJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZhY3Rvcl9pZD0wJmtleV9pZD0wJnJlcG9faWQ9MCJ9.ysA3rHJruo3q0QVk5Q0iWFm8aEeE-LwgfEUfkF5F0es";>
   
   Why yes, that does help! 😍 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org