rohitpawar2811 commented on PR #23155: URL: https://github.com/apache/superset/pull/23155#issuecomment-2158649087
> Hey @rusackas, @rohitpawar2811, playing about with the API a bit, it seems that there is an Enum called [POST_PROCESSED](https://github.com/apache/superset/blob/5660f8e5542b78e098c42306633c182d9a631d63/superset/common/chart_data.py#L45) that is what is causing the additional index to be added. This is set [here](https://github.com/apache/superset/blob/5660f8e5542b78e098c42306633c182d9a631d63/superset/commands/report/execute.py#L162) in the report execution for the CSV datatype. If this is left blank, at least in the API, it returns the same data minus the index. > > We could add the config check to this point instead. WDYT? @SkinnyPigeon Yes, initially when I looked into it, I found the same: that post-processing was adding the index. However, by making the check there, we were disturbing a lot of other checks. That's why I moved on from that approach. Actually there are some ingesters that are using csv/data download api, when I make changes in Post_Processing that ingesters check failed. I think we have to go with Post_Processing but it needs a lot of refectoring. WDYT? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
