john-bodley commented on PR #29225: URL: https://github.com/apache/superset/pull/29225#issuecomment-2163629005
Thanks @ayush33143314 for adding the engine. Would you also mind: - Adding unit/integration tests (where necessary) - Updating the various documentation which outlines which engines we support etc. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org