hainenber commented on code in PR #29118: URL: https://github.com/apache/superset/pull/29118#discussion_r1638419013
########## superset-frontend/src/dashboard/components/PropertiesModal/PropertiesModal.test.jsx: ########## @@ -16,10 +16,15 @@ * specific language governing permissions and limitations * under the License. */ -import { render } from 'spec/helpers/testing-library'; +import { mount } from 'enzyme'; +import { Provider } from 'react-redux'; Review Comment: Thanks! I've refactored this away in HEAD. Might be I'll raise another PR for a linter rule guarding this :D -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org