fisjac commented on code in PR #27962:
URL: https://github.com/apache/superset/pull/27962#discussion_r1640023515
##########
tests/integration_tests/dashboards/api_tests.py:
##########
@@ -869,6 +869,185 @@ def test_get_dashboards_created_by_me(self):
for key, value in expected_results[idx].items():
assert response_item[key] == value
+ def test_get_dashboard_tabs(self):
+ """
+ Dashboard API: Test get dashboard tabs
+ """
+ position_data = {
+ "GRID_ID": {"children": [], "id": "GRID_ID", "type": "GRID"},
+ "ROOT_ID": {
+ "children": ["TABS-tDGEcwZ82u"],
+ "id": "ROOT_ID",
+ "type": "ROOT",
+ },
+ "TAB-0TkqQRxzg7": {
+ "children": [],
+ "id": "TAB-0TkqQRxzg7",
+ "meta": {"text": "P2 - T1"},
+ "type": "TAB",
+ },
+ "TAB-1iG_yOlKA2": {
+ "children": [],
+ "id": "TAB-1iG_yOlKA2",
+ "meta": {"text": "P1 - T1"},
+ "type": "TAB",
+ },
+ "TAB-2dgADEurF": {
+ "children": ["TABS-LsyXZWG2rk"],
+ "id": "TAB-2dgADEurF",
+ "meta": {"text": "P1 - T2"},
+ "type": "TAB",
+ },
+ "TAB-BJIt5SdCx3": {
+ "children": [],
+ "id": "TAB-BJIt5SdCx3",
+ "meta": {"text": "P1 - T2 - T1"},
+ "type": "TAB",
+ },
+ "TAB-CjZlNL5Uz": {
+ "children": ["TABS-Ji_K1ZBE0M"],
+ "id": "TAB-CjZlNL5Uz",
+ "meta": {"text": "Parent Tab 2"},
+ "type": "TAB",
+ },
+ "TAB-Nct5fiHtn": {
+ "children": [],
+ "id": "TAB-Nct5fiHtn",
+ "meta": {"text": "P1 - T2 - T3"},
+ "type": "TAB",
+ },
+ "TAB-PumuDkWKq": {
+ "children": [],
+ "id": "TAB-PumuDkWKq",
+ "meta": {"text": "P2 - T2"},
+ "type": "TAB",
+ },
+ "TAB-hyTv5L7zz": {
+ "children": [],
+ "id": "TAB-hyTv5L7zz",
+ "meta": {"text": "P1 - T2 - T2"},
+ "type": "TAB",
+ },
+ "TAB-qL7fSzr3jl": {
+ "children": ["TABS-N8ODUqp2sE"],
+ "id": "TAB-qL7fSzr3jl",
+ "meta": {"text": "Parent Tab 1"},
+ "type": "TAB",
+ },
+ "TABS-Ji_K1ZBE0M": {
+ "children": ["TAB-0TkqQRxzg7", "TAB-PumuDkWKq"],
+ "id": "TABS-Ji_K1ZBE0M",
+ "meta": {},
+ "type": "TABS",
+ },
+ "TABS-LsyXZWG2rk": {
+ "children": ["TAB-BJIt5SdCx3", "TAB-hyTv5L7zz",
"TAB-Nct5fiHtn"],
+ "id": "TABS-LsyXZWG2rk",
+ "meta": {},
+ "type": "TABS",
+ },
+ "TABS-N8ODUqp2sE": {
+ "children": ["TAB-1iG_yOlKA2", "TAB-2dgADEurF"],
+ "id": "TABS-N8ODUqp2sE",
+ "meta": {},
+ "type": "TABS",
+ },
+ "TABS-tDGEcwZ82u": {
+ "children": ["TAB-qL7fSzr3jl", "TAB-CjZlNL5Uz"],
+ "id": "TABS-tDGEcwZ82u",
+ "meta": {},
+ "type": "TABS",
+ },
+ }
+ admin_id = self.get_user("admin").id
+ dashboard = self.insert_dashboard(
+ "title", "slug", [admin_id],
position_json=json.dumps(position_data)
+ )
+ self.login(ADMIN_USERNAME)
+ uri = f"api/v1/dashboard/{dashboard.id}/tabs"
+ rv = self.get_assert_metric(uri, "get_tabs")
+ response = json.loads(rv.data.decode("utf-8"))
+ expected_response = {
+ "result": {
+ "all_tabs": {
+ "TAB-0TkqQRxzg7": "P2 - T1",
+ "TAB-1iG_yOlKA2": "P1 - T1",
+ "TAB-2dgADEurF": "P1 - T2",
+ "TAB-BJIt5SdCx3": "P1 - T2 - T1",
+ "TAB-CjZlNL5Uz": "Parent Tab 2",
+ "TAB-Nct5fiHtn": "P1 - T2 - T3",
+ "TAB-PumuDkWKq": "P2 - T2",
+ "TAB-hyTv5L7zz": "P1 - T2 - T2",
+ "TAB-qL7fSzr3jl": "Parent Tab 1",
+ },
+ "tab_tree": [
+ {
+ "children": [
+ {
+ "children": [],
+ "title": "P1 - T1",
+ "value": "TAB-1iG_yOlKA2",
+ },
+ {
+ "children": [
+ {
+ "children": [],
+ "title": "P1 - T2 - T1",
+ "value": "TAB-BJIt5SdCx3",
+ },
+ {
+ "children": [],
+ "title": "P1 - T2 - T2",
+ "value": "TAB-hyTv5L7zz",
+ },
+ {
+ "children": [],
+ "title": "P1 - T2 - T3",
+ "value": "TAB-Nct5fiHtn",
+ },
+ ],
+ "title": "P1 - T2",
+ "value": "TAB-2dgADEurF",
+ },
+ ],
+ "title": "Parent Tab 1",
+ "value": "TAB-qL7fSzr3jl",
+ },
+ {
+ "children": [
+ {
+ "children": [],
+ "title": "P2 - T1",
+ "value": "TAB-0TkqQRxzg7",
+ },
+ {
+ "children": [],
+ "title": "P2 - T2",
+ "value": "TAB-PumuDkWKq",
+ },
+ ],
+ "title": "Parent Tab 2",
+ "value": "TAB-CjZlNL5Uz",
+ },
+ ],
+ }
+ }
+ self.assertEqual(rv.status_code, 200)
+ self.assertEqual(response, expected_response)
+ db.session.delete(dashboard)
+ db.session.commit()
+
+ @pytest.mark.usefixtures("load_world_bank_dashboard_with_slices")
Review Comment:
currently the only tests that explicitly check permissions for the dashboard
api are for PUT and DELETE requests. My understanding is that the
FlaskAppbuilder @protect decorator is doing most of the work for ensuring
permissions for GET requests. Presumably the @protect decorator is being tested
somewhere else within the codebase?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
