justinpark commented on code in PR #29242:
URL: https://github.com/apache/superset/pull/29242#discussion_r1640226231
##########
superset-frontend/src/components/Chart/DrillBy/DrillByMenuItems.tsx:
##########
@@ -119,51 +157,59 @@ export const DrillByMenuItems = ({
const verboseMap = useVerboseMap(dataset);
useEffect(() => {
+ async function loadOptions() {
+ const datasetId = +formData.datasource.split('__')[0];
Review Comment:
While this method seems convenient, it might cause misunderstandings for
those not familiar with JavaScript. Therefore, it would be better to apply a
more explicit number conversion function.
```suggestion
const datasetId = Number(formData.datasource.split('__')[0]);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
