hainenber commented on code in PR #29265:
URL: https://github.com/apache/superset/pull/29265#discussion_r1641897913
##########
superset-frontend/cypress-base/cypress/e2e/dashboard/nativeFilters.test.ts:
##########
@@ -428,14 +428,13 @@ describe('Native filters', () => {
cy.contains(testItems.filterDefaultValue).should('be.visible');
cy.contains(testItems.filterOtherCountry).should('not.exist');
});
+ validateFilterContentOnDashboard(testItems.filterDefaultValue);
// reload dashboard
cy.reload();
cy.get(dataTestChartName(testItems.topTenChart.name)).within(() => {
cy.contains(testItems.filterDefaultValue).should('be.visible');
- cy.contains(testItems.filterOtherCountry).should('not.exist');
Review Comment:
`cy.reload()` in Cypress 13 seems to completely remove local cache for
stored filter inputs. Lmk if my change here is a fix or a band-aid :D
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
