jessie-ross commented on code in PR #27777:
URL: https://github.com/apache/superset/pull/27777#discussion_r1648418971


##########
superset/utils/logging_configurator.py:
##########
@@ -41,19 +41,11 @@ def configure_logging(
         if app_config["SILENCE_FAB"]:
             logging.getLogger("flask_appbuilder").setLevel(logging.ERROR)
 
-        # configure superset app logger
-        superset_logger = logging.getLogger("superset")

Review Comment:
   Yes, I think that's a very good idea. It is technically a breaking change, 
but only for debug-level environments so should be acceptable.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

Reply via email to