rusackas commented on code in PR #29580:
URL: https://github.com/apache/superset/pull/29580#discussion_r1681403263
##########
superset/config.py:
##########
@@ -370,6 +370,7 @@ def _try_json_readsha(filepath: str, length: int) -> str |
None:
"en": {"flag": "us", "name": "English"},
"es": {"flag": "es", "name": "Spanish"},
"it": {"flag": "it", "name": "Italian"},
+ "fa": {"flag": "ir", "name": "Persian"},
Review Comment:
It's good to add this here, but line 389 below disables this whole block.
For testing purposes, you can add a few languages there and they should show up
on the ephemeral/test environments on this PR.
Sorry I haven't had time to build/test this locally yet... I'm still hoping
to.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
