michael-s-molina commented on code in PR #29672:
URL: https://github.com/apache/superset/pull/29672#discussion_r1690124530
##########
superset-frontend/src/components/AsyncAceEditor/index.tsx:
##########
@@ -167,15 +172,66 @@ export default function AsyncAceEditor(
}, [keywords, setCompleters]);
return (
- <ReactAceEditor
- ref={ref}
- mode={mode}
- theme={theme}
- tabSize={tabSize}
- defaultValue={defaultValue}
- setOptions={{ fontFamily }}
- {...props}
- />
+ <>
+ <Global
+ styles={css`
+ .ace_tooltip {
Review Comment:
@justinpark I noticed that
`src/SqlLab/components/AceEditorWrapper/index.tsx` has similar logic as this
code. Is it possible to avoid code duplication in this case and also ensure
similar behavior for both editors by using a single component?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
