rusackas commented on code in PR #29779:
URL: https://github.com/apache/superset/pull/29779#discussion_r1697384232
##########
docker/docker-frontend.sh:
##########
@@ -24,12 +24,15 @@ if [ "$PUPPETEER_SKIP_CHROMIUM_DOWNLOAD" = "false" ]; then
fi
if [ "$BUILD_SUPERSET_FRONTEND_IN_DOCKER" = "true" ]; then
+ echo "Building Superset frontend in dev mode inside docker container"
cd /app/superset-frontend
- npm install -f --no-optional --global webpack webpack-cli
- npm install -f --no-optional
+
+ echo "Running `npm install`"
+ npm install
echo "Running frontend"
npm run dev
+
else
- echo "Skipping frontend build steps - YOU RUN IT MANUALLY ON THE HOST!"
+ echo "Skipping frontend build steps - YOU NEED TO RUN IT MANUALLY ON THE
HOST!"
Review Comment:
Maybe the link will help? ¯\_(ツ)_/¯
##########
docker/docker-frontend.sh:
##########
@@ -24,12 +24,15 @@ if [ "$PUPPETEER_SKIP_CHROMIUM_DOWNLOAD" = "false" ]; then
fi
if [ "$BUILD_SUPERSET_FRONTEND_IN_DOCKER" = "true" ]; then
+ echo "Building Superset frontend in dev mode inside docker container"
cd /app/superset-frontend
- npm install -f --no-optional --global webpack webpack-cli
- npm install -f --no-optional
+
+ echo "Running `npm install`"
+ npm install
echo "Running frontend"
npm run dev
+
else
- echo "Skipping frontend build steps - YOU RUN IT MANUALLY ON THE HOST!"
+ echo "Skipping frontend build steps - YOU NEED TO RUN IT MANUALLY ON THE
HOST!"
Review Comment:
Maybe the link will help? ¯\\\_(ツ)_/¯
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
