ayush-couchbase commented on code in PR #29911:
URL: https://github.com/apache/superset/pull/29911#discussion_r1714176993
##########
superset/db_engine_specs/couchbase.py:
##########
@@ -74,14 +74,15 @@ class CouchbaseParametersSchema(Schema):
)
-class CouchbaseDbEngineSpec(BasicParametersMixin, BaseEngineSpec):
- engine = "couchbasedb"
+class CouchbaseEngineSpec(BasicParametersMixin, BaseEngineSpec):
+ engine = "couchbase"
+ engine_aliases = {"couchbase", "couchbasedb"}
Review Comment:
There are 2 failed checks, but they were not failing earlier, are they
because of my patch ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
