rusackas commented on code in PR #25454:
URL: https://github.com/apache/superset/pull/25454#discussion_r1723877543
##########
tests/integration_tests/databases/api_tests.py:
##########
@@ -2185,17 +2185,17 @@ def test_test_connection_failed_invalid_hostname(
"""
Database API: Test test connection failed due to invalid hostname
"""
- msg = 'psql: error: could not translate host name "locahost" to
address: nodename nor servname provided, or not known'
+ msg = 'psql: error: could not translate host name "localhost_" to
address: nodename nor servname provided, or not known'
mock_build_db.return_value.set_sqlalchemy_uri.side_effect = DBAPIError(
msg, None, None
)
mock_build_db.return_value.db_engine_spec.__name__ = "Some name"
superset_error = SupersetError(
- message='Unable to resolve hostname "locahost".',
+ message='Unable to resolve hostname "localhost_".',
error_type="CONNECTION_INVALID_HOSTNAME_ERROR",
level="error",
extra={
- "hostname": "locahost",
+ "hostname": "localhost_",
Review Comment:
```suggestion
"hostname": "localhost",
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
