rmasters commented on PR #28706: URL: https://github.com/apache/superset/pull/28706#issuecomment-2299834664
Apologies for the radio silence; I don't seem to be getting github notifications through to my email... Many thanks for the reviews. I'll rebase and pop that refactor to utils in shortly. --- > @talfour Thanks for providing solution, however this wouldn't work if someone is using superset-websockets as in the headers there are two "Set-Cookie"'s first one is an async-token and second session token, your code will get the first one which is wrong and you'll get 404 UNATHORIZED I'm not familiar with the websocket server, but am I right in understanding that it should **not** pick up the async/websocket-server cookie? It doesn't appear that the FAB session cookie name can be changed from `session` so I can filter for that (it has been years since I used FAB though so if anyone knows different please lmk). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
