mistercrunch commented on code in PR #29974:
URL: https://github.com/apache/superset/pull/29974#discussion_r1724151937
##########
superset-frontend/src/hooks/apiResources/tables.ts:
##########
@@ -117,6 +117,13 @@ const tableApi = api.injectEndpoints({
}),
}),
tableMetadata: builder.query<TableMetaData,
FetchTableMetadataQueryParams>({
+ providesTags: result =>
+ result
+ ? [
+ { type: 'TableMetadatas', id: result.name },
Review Comment:
what is `result.name` in this context? Is it a fully-qualified table name?
Regardless I think at this time changing anything in the table selector flushes
the metadata section, so even just a table name should be safe for now. If we
were to support tables from multiple schemas to remain accessible in this
metadata section, this could in theory create some collision.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
