justinpark opened a new pull request, #30141:
URL: https://github.com/apache/superset/pull/30141

   ### SUMMARY
   In certain cases, a race condition was observed where the cursor position in 
the Redux state and the cursor position in the ACE editor would repeatedly 
update each other.
   This commit modifies the behavior to update the position only when the 
current cursor position differs from the value in the Redux state, in order to 
prevent this issue.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   
   Before:
   
   
https://github.com/user-attachments/assets/8992a0b6-5763-4471-8921-63c10c7622d1
   
   After:
   
   No maximum update depth exceeded error thrown
   
   ### TESTING INSTRUCTIONS
   locally
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

Reply via email to