martyngigg commented on PR #30099: URL: https://github.com/apache/superset/pull/30099#issuecomment-2328431365
Thanks for the review! > I have to admit I didn't know if the translation was more of a build-time thing or a run-time thing. Given the new logic in the webpack config it appears it's required at build time. Hoping it doesn't impact perf when using `en`, please confirm if you can. > > We may want to introduce a new `ARG build_translations=false` to speed up build and reduce image size for the large majority on a `en`-only deploy. I think this would cause more data to be loaded when the `moment-timezone` library is lazy loaded by the [time zone selector](https://github.com/apache/superset/pull/29791/files#diff-af8c7b9613aada55841f641f037e90dbe5695de25a9240096ef3e3cc907bd021R59). Before my changes the docker image would only keep the `en` timezone data but now it would include everything for the locales defined in the translations directory - I'm not sure on the exact size of this but it is only loaded when the timezone selector is made visible on the alerts/reports modal. Is the preference still to add the build flag and then also remove the translations from the backend and have the standard image be `en` only? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
