eschutho commented on code in PR #30258: URL: https://github.com/apache/superset/pull/30258#discussion_r1757555079
########## superset/db_engine_specs/base.py: ########## @@ -63,7 +63,8 @@ from superset.databases.utils import get_table_metadata, make_url_safe from superset.errors import ErrorLevel, SupersetError, SupersetErrorType from superset.exceptions import DisallowedSQLFunction, OAuth2Error, OAuth2RedirectError -from superset.sql_parse import ParsedQuery, SQLScript, Table +from superset.sql.parse import SQLScript, Table +from superset.sql_parse import ParsedQuery Review Comment: nit, but these two paths are really similar. What's the difference between them and will people be able to remember what goes where? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
