betodealmeida commented on PR #30266: URL: https://github.com/apache/superset/pull/30266#issuecomment-2368805091
> Nice. Did grepping to check if there were some rogue `create_engine` calls not going through this method and it looked squeaky cleaned. @mistercrunch yeah, when we implemented SSH tunneling we had to consolidate all the logic in a single place. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
