graceguo-supercat commented on a change in pull request #7390: [dashboard]
allow user re-order top-level tabs
URL:
https://github.com/apache/incubator-superset/pull/7390#discussion_r279217978
##########
File path: superset/assets/src/dashboard/actions/dashboardLayout.js
##########
@@ -176,11 +196,8 @@ export function handleComponentDrop(dropResult) {
dispatch(moveComponent(dropResult));
}
- const { dashboardLayout: undoableLayout } = getState();
-
// if we moved a child from a Tab or Row parent and it was the only child,
delete the parent.
if (!isNewComponent) {
- const { present: layout } = undoableLayout;
Review comment:
very important. so i reverted this change, and in the earlier place just get
a value from a needed field.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
