geido commented on PR #30252: URL: https://github.com/apache/superset/pull/30252#issuecomment-2400179736
> @geido I am testing the 4.1 branch and realized that our cross filters are not working anymore. Do I read this PR right in that it would entirely disable cross filtering if the data source is not the same, even if shared columns exist? And that this is fixed, also for columns not actually used in the chart, with: #30438 That is a good point @fmannhardt . I updated https://github.com/apache/superset/pull/30438 to make sure we are targeting all possible common columns in all datasources. Let me know if that makes sense to you now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
