betodealmeida commented on code in PR #30560: URL: https://github.com/apache/superset/pull/30560#discussion_r1793737820
########## superset/config.py: ########## @@ -48,6 +48,7 @@ from pandas._libs.parsers import STR_NA_VALUES from sqlalchemy.engine.url import URL from sqlalchemy.orm.query import Query +from sqlglot import Dialect, Dialects Review Comment: Nit: move this to inside the `if TYPE_CHECKING:` block. ########## superset/sql_parse.py: ########## @@ -88,61 +92,6 @@ lex.set_SQL_REGEX(sqlparser_sql_regex) -# mapping between DB engine specs and sqlglot dialects Review Comment: Thanks for removing the duplicate code here! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
