michael-s-molina commented on PR #30578: URL: https://github.com/apache/superset/pull/30578#issuecomment-2407883270
@betodealmeida We discussed this PR during the daily PR review meeting, and we think we should aim for removing any dependency of `sqlparse` in accordance to [[SIP-117] Improve SQL parsing](https://github.com/apache/superset/issues/26786). This means that we prefer to remove formatting for these databases in favor of removing `sqlparse`. That being said, we understand that this would constitute a breaking change given that this feature exists in 4.0 for these databases. We agreed on keeping your solution but adding a deprecation annotation/comment to the code and remove the `sqlparse` dependency in 5.0 even if the dialects are not correctly supported by then. I added the following [ticket](https://github.com/orgs/apache/projects/345?pane=issue&itemId=83111151) to the 5.0 board. cc @villebro @justinpark @sadpandajoe -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
