justinpark commented on code in PR #30653:
URL: https://github.com/apache/superset/pull/30653#discussion_r1809213724
##########
superset/sql_lab.py:
##########
@@ -240,17 +240,15 @@ def execute_sql_statement( # pylint:
disable=too-many-statements, too-many-loca
increased_limit = None if query.limit is None else query.limit + 1
if not database.allow_dml:
- errors = []
try:
parsed_statement = SQLStatement(sql_statement,
engine=db_engine_spec.engine)
disallowed = parsed_statement.is_mutating()
- except SupersetParseError as ex:
- # if we fail to parse the query, disallow by default
+ except SupersetParseError:
+ # if we fail to parse teh query, disallow by default
Review Comment:
nit: typo
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
