villebro commented on PR #30438: URL: https://github.com/apache/superset/pull/30438#issuecomment-2427485997
I didn't review these changes, but it was my understanding that 1. by default, native and cross filters will only be scoped to charts using the same dataset 2. If one wants the filters to apply to charts that aren't using the same dataset, one simply adds them to the filter scope Similar to the comments above, I know of many use cases where there's jinja logic that intercepts filters for columns that aren't present in the dataset, and use those to modify the chart query somehow. I'm not sure if this has been explicitly stated as a feature that Superset supports, but I think this use case has been well established for a longer time already, hence I feel removing it will be problematic. Does this PR break said workflow? I'm happy to jump on a sync call to discuss this if needed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
