villebro commented on code in PR #30412:
URL: https://github.com/apache/superset/pull/30412#discussion_r1817149817
##########
superset/db_engine_specs/base.py:
##########
@@ -437,6 +437,14 @@ class BaseEngineSpec: # pylint:
disable=too-many-public-methods
# Driver-specific exception that should be mapped to OAuth2RedirectError
oauth2_exception = OAuth2RedirectError
+ # Does the query id related to the connection?
+ # The default value is True, which means that the query id is determined
when
+ # the connection is created.
+ # When this is changed to false in a DB engine spec it means the query id
+ # is determined only after the specific query is executed and it will
update
+ # the `cancel_query` value in the `extra` field of the `query` object
+ is_query_id_associated_connect = True
Review Comment:
I like the comment, however, I find the property name difficult to
understand. Could we rename this to something more descriptive, like
`has_query_id_before_execute` or something similar.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
