cezudas opened a new pull request, #30724: URL: https://github.com/apache/superset/pull/30724
### SUMMARY <!--- Describe the change below, including rationale and design decisions --> When a dashboard is loaded in embedded mode, no 'Edit chart' functionality makes sense regardless of whether the guest user has `supersetCanExplore` permission. Why? Because the `/explore` page isn't available in the DashboardEmbed mode so if the role provided for `GUEST_ROLE_NAME` has `supersetCanExplore` permission the 'Edit chart' functionality would not work (guest user will see a blank page in the embed mode) ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF <!--- Skip this if not applicable --> ### TESTING INSTRUCTIONS <!--- Required! What steps can be taken to manually verify the changes? -->  ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Required feature flags: - [x] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
