Vitor-Avila commented on PR #30721: URL: https://github.com/apache/superset/pull/30721#issuecomment-2444672963
> LGTM, however, it's worth remembering that the rendered query can change, considerably even, if it has lots of conditional Jinja logic. It's pretty common to see additional where clauses added if certain filter parameters are set in the chart data request. Just something to keep in mind. @villebro that's true. I actually decided to include both the regular `sql` and `expression` values and then add `rendered_sql` and `rendered_expression` if the param is present, so that users still get the original value. I think having both data is helpful for such cases. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
