Vitor-Avila commented on PR #30833: URL: https://github.com/apache/superset/pull/30833#issuecomment-2475288129
> Taking a look at this, but in the meantime a few comments: > > 1. I like the approach of having `tags.yml` in the ZIP, I think it aligns super well with the intent of the import/export flow. > 2. Using `inspect` to figure out the caller makes me nervous, let's see if we can find a better solution. > 3. Every time we change import/export we need to make sure that (1) old exports still work, and (2) new exports work in older version — that is, everything should be backwards and forwards compatible, ideally. Thanks @betodealmeida! I can help testing 3 if needed. I agree with 1 and 2 - I'm wondering if there's a better way to handle this flow. Another consideration is if we should adopt the similar `uuid` approach for tags, and also allow exporting tags via the UI (as an individual object type), and then the `uuid` would dictate if the tag gets updated or created. I don't think it's worth in the current scope, but if we end up expanding its features (for example, the ability to assign permissions to tags, etc) might be beneficial. This can also be re-evaluated if we ever get there -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
