Vitor-Avila commented on code in PR #31199:
URL: https://github.com/apache/superset/pull/31199#discussion_r1865959984
##########
superset/db_engine_specs/databricks.py:
##########
@@ -464,8 +464,10 @@ def get_prequeries(
) -> list[str]:
prequeries = []
if catalog:
+ catalog = f"`{catalog}`" if not catalog.startswith("`") else
catalog
Review Comment:
I didn't use `database.quote_identifier()`, because the `Database` is no
longer passed as an argument in `>=4.1.0`:
https://github.com/apache/superset/blob/4.1.0/superset/db_engine_specs/base.py#L1412-L1431
Since this method is specifically for Databricks, I thought it was OK to
hardcode the quote identifiers.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
