geido commented on code in PR #31168:
URL: https://github.com/apache/superset/pull/31168#discussion_r1866016284
##########
superset-frontend/src/components/Alert/index.tsx:
##########
@@ -55,33 +57,32 @@ export default function Alert(props: AlertProps) {
return (
<AntdAlert
role="alert"
+ aria-live={type === 'error' ? 'assertive' : 'polite'}
showIcon={showIcon}
- icon={<AlertIcon aria-label={`${type} icon`} />}
- closeText={closable && <Icons.XSmall aria-label="close icon" />}
- css={{
+ icon={
+ showIcon && (
+ <span
+ role="img"
+ aria-label={`${type} icon`}
+ style={{
+ color: baseColor.base,
+ }}
+ >
+ <AlertIcon />
+ </span>
+ )
+ }
+ closeIcon={closable && <Icons.XSmall aria-label="close icon" />}
+ message={children || 'Default message'}
+ description={description}
+ style={{
Review Comment:
Do we still need these styles here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
