villebro commented on code in PR #31265:
URL: https://github.com/apache/superset/pull/31265#discussion_r1868273636


##########
superset/db_engine_specs/trino.py:
##########
@@ -283,6 +286,8 @@ def _execute(
         )
         execute_thread.start()
 
+        # Wait for the thread to start before continuing
+        time.sleep(0.1)

Review Comment:
   @michael-s-molina I don't think that would work, as `.set()` is only called 
once the thread is completed. Should we perhaps be checking that 
`execute_thread.is_alive()` is returning `True` before proceeding? I think 
that's what we're trying to do here.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

Reply via email to