sadpandajoe commented on code in PR #31332:
URL: https://github.com/apache/superset/pull/31332#discussion_r1874133150
##########
superset/migrations/versions/2024-05-01_10-52_58d051681a3b_add_catalog_perm_to_tables.py:
##########
@@ -45,10 +49,21 @@ def upgrade():
"slices",
sa.Column("catalog_perm", sa.String(length=1000), nullable=True),
)
+
+ if not table_has_index(perm_table, perm_index_view_menu):
Review Comment:
might be good to add these into a helper function call create_index that
will do the check and add it like here
https://github.com/apache/superset/pull/31303
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
