yousoph opened a new issue, #31369:
URL: https://github.com/apache/superset/issues/31369

   ### Bug description
   
   ## Description
   Users can save queries from the SQL Lab for future reference or reusability. 
However, accessing the saved queries from the list creates a new saved query 
upon saving the changes rather than updating the existing saved query 
   
   ## How to reproduce the bug
   1. Run a query in the SQL Lab.
   2. Save the query.
   3. Close the query tab.
   4. Access the saved query from the **SQL > Saved Queries** menu.
   5. Perform some changes and save.
   
   ## Expected results
   The query will have an update or save as new option. User should see a Save 
As modal that allows them to update their current query (see screenshots below) 
   
   ## Actual results
   The query can only be saved as a new saved query.
   
   ## Other Details
   Query can be updated as long as the query tab is not closed. Any tabs that 
are opened later will show the incorrect modal without the Save as New / Update 
options. 
   
   ### Screenshots/recordings
   
   What the user currently sees when trying to save a query: 
   <img width="638" alt="image" 
src="https://github.com/user-attachments/assets/98442801-77f5-41ff-911f-c2e1d4275766";>
   
   
   Save modal should look like the below when editing your existing query: 
   <img width="641" alt="image" 
src="https://github.com/user-attachments/assets/58d0b2ec-b5c7-49f2-92a0-bf679fad2495";>
   
   
   ### Superset version
   
   master / latest-dev
   
   ### Python version
   
   3.9
   
   ### Node version
   
   16
   
   ### Browser
   
   Chrome
   
   ### Additional context
   
   _No response_
   
   ### Checklist
   
   - [X] I have searched Superset docs and Slack and didn't find a solution to 
my problem.
   - [X] I have searched the GitHub issue tracker and didn't find a similar bug 
report.
   - [ ] I have checked Superset's logs for errors and if I found a relevant 
Python stacktrace, I included it here as text in the "additional context" 
section.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

Reply via email to