rusackas commented on PR #28203: URL: https://github.com/apache/superset/pull/28203#issuecomment-2537261031
Thanks for getting the tests passing! I will ping @villebro as a more capable reviewer than myself when it comes to query context, but I suspect if we don't merge it, the reason would be for need of additional test coverage around handling of verbose maps, ad hoc metrics, ad hoc columns, and error handling. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org