MohamedHalat commented on code in PR #31331:
URL: https://github.com/apache/superset/pull/31331#discussion_r1894174170
##########
superset-embedded-sdk/src/index.ts:
##########
@@ -71,11 +71,12 @@ export type Size = {
}
export type EmbeddedDashboard = {
- getScrollSize: () => Promise<Size>
- unmount: () => void
- getDashboardPermalink: (anchor: string) => Promise<string>
- getActiveTabs: () => Promise<string[]>
-}
+ getScrollSize: () => Promise<Size>;
+ unmount: () => void;
+ getDashboardPermalink: (anchor: string) => Promise<string>;
+ getActiveTabs: () => Promise<string[]>;
+ getDataMasks: (callbackFn: (dataMasks: any[]) => void) => void;
Review Comment:
No need to unsubscribe as Switchboard will continue to send requests
nonetheless
##########
superset-embedded-sdk/src/index.ts:
##########
@@ -71,11 +71,12 @@ export type Size = {
}
export type EmbeddedDashboard = {
- getScrollSize: () => Promise<Size>
- unmount: () => void
- getDashboardPermalink: (anchor: string) => Promise<string>
- getActiveTabs: () => Promise<string[]>
-}
+ getScrollSize: () => Promise<Size>;
+ unmount: () => void;
+ getDashboardPermalink: (anchor: string) => Promise<string>;
+ getActiveTabs: () => Promise<string[]>;
+ getDataMasks: (callbackFn: (dataMasks: any[]) => void) => void;
Review Comment:
No need to unsubscribe as Switchboard will continue to send messages
nonetheless
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
