DiggidyDave commented on a change in pull request #7449: Only allow GET method
for explore_json by feature flag
URL:
https://github.com/apache/incubator-superset/pull/7449#discussion_r281743223
##########
File path: superset/views/core.py
##########
@@ -1238,9 +1239,12 @@ def explore_json(self, datasource_type=None,
datasource_id=None):
requests that GETs or POSTs a form_data.
`self.generate_json` receives this input and returns different
- payloads based on the request args in the first block
+ payloads based on the request args in the first block"""
- TODO: break into one endpoint for each return shape"""
+ if request.method != 'POST' and not is_feature_enabled('CLIENT_CACHE'):
Review comment:
Also just to be clear, my concern above may not be well-founded--maybe it
doesn't need to be treated as a public API--but I did want to raise it for
discussion. (Probably good to make the expose params match behavior in either
case?)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
