mistercrunch commented on code in PR #31587:
URL: https://github.com/apache/superset/pull/31587#discussion_r1904798885
##########
superset/databases/utils.py:
##########
@@ -55,7 +55,7 @@ def get_indexes_metadata(
def get_col_type(col: dict[Any, Any]) -> str:
try:
- dtype = f"{col['type']}"
+ dtype = f"{[col['type']]}"[1:-1]
Review Comment:
Hard for me to make sense of this line of code before and after the change.
Maybe needs a comment, docstring and/or better typing?
Also if this is solving a trino-specific issue, does it belong somewhere in
db_engine_spec?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
