korbit-ai[bot] commented on code in PR #32043:
URL: https://github.com/apache/superset/pull/32043#discussion_r1935837916
##########
superset/config.py:
##########
@@ -1905,6 +1905,15 @@ class ExtraDynamicQueryFilters(TypedDict, total=False):
EXTRA_DYNAMIC_QUERY_FILTERS: ExtraDynamicQueryFilters = {}
+# The migrations that add catalog permissions might take a considerably long
time
+# to execute as it has to create permissions to all schemas and catalogs from
all
+# other catalogs accessible by the credentials. This flag allows to skip the
+# creation of these secondary perms, and focus only on permissions for the
default
+# catalog. These secondary permissions can be created later by editing the DB
+# connection via the UI (without downtime).
+CATALOGS_SIMPLIFIED_MIGRATION: bool = False
Review Comment:
### Default value of CATALOGS_SIMPLIFIED_MIGRATION negates intended
performance improvement <sub></sub>
<details>
<summary>Tell me more</summary>
###### What is the issue?
The new flag is set to False by default, which does not align with the
developer's intent to help reduce execution time of catalog migrations.
###### Why this matters
Users won't get the performance benefits of skipping secondary permissions
during catalog migrations unless they explicitly set the flag to True in their
configuration.
###### Suggested change ∙ *Feature Preview*
The default value should match the developer's intent for improved
performance:
```python
CATALOGS_SIMPLIFIED_MIGRATION: bool = True
```
</details>
<sub>
[](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/bf955330-c2fe-4db3-aa70-b3fada44c887?suggestedFixEnabled=true)
💬 Chat with Korbit by mentioning @korbit-ai.
</sub>
<!--- korbi internal id:453b8a76-cd1a-4cb9-a488-7ebcabb34858 -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
