korbit-ai[bot] commented on code in PR #32045:
URL: https://github.com/apache/superset/pull/32045#discussion_r1935858000
##########
scripts/cypress_run.py:
##########
@@ -60,7 +60,6 @@ def run_cypress_for_test_file(
f"--browser {browser} "
f"--record --group {group_id} --tag {REPO},{GITHUB_EVENT_NAME}
"
f"--ci-build-id {build_id} "
- f"--wait-for-missing-groups "
f"-- {chrome_flags}"
Review Comment:
### Parallel Test Synchronization Issue <sub></sub>
<details>
<summary>Tell me more</summary>
###### What is the issue?
Removing the '--wait-for-missing-groups' flag in parallel Cypress test
execution could lead to test runs completing before all parallel groups are
ready, potentially missing test failures in other groups.
###### Why this matters
In a CI environment with parallel test execution, not waiting for all groups
can result in false positives where the build is marked as successful even if
other parallel groups later fail.
###### Suggested change ∙ *Feature Preview*
Retain the '--wait-for-missing-groups' flag to ensure proper synchronization
between parallel test groups:
```python
f"--browser {browser} "
f"--record --group {group_id} --tag {REPO},{GITHUB_EVENT_NAME} "
f"--ci-build-id {build_id} "
f"--wait-for-missing-groups "
f"-- {chrome_flags}"
```
</details>
<sub>
[](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/ee41bf17-7e22-45e2-8a72-99c24881604d?suggestedFixEnabled=true)
💬 Chat with Korbit by mentioning @korbit-ai.
</sub>
<!--- korbi internal id:43b63b5d-da52-48fe-83fe-1df7d7f2a5c6 -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
