Re: [PR] refactor(Icons): Replaces custom icons with Ant Design 5 icons [superset]

[via GitHub]

korbit-ai[bot] commented on code in PR #32112:
URL: https://github.com/apache/superset/pull/32112#discussion_r1938610226


##########
superset-frontend/src/features/charts/ChartCard.tsx:
##########
@@ -100,7 +100,7 @@ export default function ChartCard({
                 className="action-button"
                 onClick={confirmDelete}
               >
-                <Icons.Trash iconSize="l" /> {t('Delete')}
+                <Icons.DeleteOutlined iconSize="l" /> {t('Delete')}

Review Comment:
   ### Invalid prop passed to AntDesign icon <sub>![category 
Functionality](https://img.shields.io/badge/Functionality-0284c7)</sub>
   
   <details>
     <summary>Tell me more</summary>
   
   ###### What is the issue?
   The iconSize prop is being passed to AntDesign's DeleteOutlined icon 
component, but AntDesign icons don't support this prop, which could cause the 
icon to render incorrectly or not at all.
   
   ###### Why this matters
   This will cause the icon sizing to not work as expected, breaking the visual 
consistency of the UI. AntDesign icons use different props for sizing like 
'style={{ fontSize: size }}' or the 'size' prop.
   
   ###### Suggested change ∙ *Feature Preview*
   Replace the iconSize prop with the appropriate AntDesign icon sizing method. 
For example:
   ```tsx
   <Icons.DeleteOutlined style={{ fontSize: 16 }} /> {t('Delete')}
   ```
   or if using a custom wrapper:
   ```tsx
   <Icons.DeleteOutlined size={16} /> {t('Delete')}
   ```
   
   
   </details>
   
   <sub>
   
   [![Report a problem with this 
comment](https://img.shields.io/badge/Report%20a%20problem%20with%20this%20comment-gray.svg?logo=data:image/svg+xml;base64,PHN2ZyB4bWxucz0iaHR0cDovL3d3dy53My5vcmcvMjAwMC9zdmciIHdpZHRoPSIyNCIgaGVpZ2h0PSIyNCIgdmlld0JveD0iMCAwIDI0IDI0IiBmaWxsPSJub25lIiBzdHJva2U9IiNmNWVjMDAiIHN0cm9rZS13aWR0aD0iMiIgc3Ryb2tlLWxpbmVjYXA9InJvdW5kIiBzdHJva2UtbGluZWpvaW49InJvdW5kIiBjbGFzcz0ibHVjaWRlIGx1Y2lkZS10cmlhbmdsZS1hbGVydCI+PHBhdGggZD0ibTIxLjczIDE4LTgtMTRhMiAyIDAgMCAwLTMuNDggMGwtOCAxNEEyIDIgMCAwIDAgNCAyMWgxNmEyIDIgMCAwIDAgMS43My0zIi8+PHBhdGggZD0iTTEyIDl2NCIvPjxwYXRoIGQ9Ik0xMiAxN2guMDEiLz48L3N2Zz4=)](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/3fe12402-496e-4ac1-9cb9-2f92b6a59b24?suggestedFixEnabled=true)
   
   💬 Chat with Korbit by mentioning @korbit-ai.
   </sub>
   
   <!--- korbi internal id:38e7821d-077d-4ec1-8424-7f35dea7544a -->
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org