betodealmeida commented on code in PR #32156:
URL: https://github.com/apache/superset/pull/32156#discussion_r1944990570


##########
superset/charts/api.py:
##########
@@ -623,7 +623,7 @@ def build_response(status_code: int) -> WerkzeugResponse:
 
         if cache_payload.should_trigger_task(force):
             logger.info("Triggering screenshot ASYNC")
-            screenshot_obj.cache.set(cache_key, ScreenshotCachePayload())
+            screenshot_obj.cache.set(cache_key, 
ScreenshotCachePayload().to_dict())

Review Comment:
   > Readability counts. -- Zen of Python



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

Reply via email to